Skip to content

Pass content disposition in query when no cdn used

Erick Bajao requested to merge eb-fix-content-disposition-no-cdn into master

This is extracted from !106740 (merged) to reduce noise from the original MR.

This issue was discovered during implementation of !106740 (merged). Given the objects uploaded will now be having random generated hashes instead of the original filename, during my testing locally, wherein no CDN was used, when I download the file uploaded, I would see the random hash in the download dialog instead of the original filename.

This MR fixes the problem by ensuring that we also pass the correct content disposition in the query params.

Please note that currently, this is not noticeable to self-managed instances because object names are in original filename format still, and in gitlab.com, we use CDN. But once !106740 (merged) is released, job artifacts will have the random generated hash as the object's name, so self-managed instances that don't use CDN will see the problem suddenly.

Merge request reports

Loading