Skip to content

Render mr note in finding modal

Samantha Ming requested to merge 391741-render-mr-note-modal into master

What does this MR do and why?

In this MR, the MR note is rendered in the finding modal

Screenshots or screen recordings

MR + Issue MR
image image

Note: the UI is slightly different (from production) when there is an issue, I'll fix that in this issue > #391731

How to set up and validate locally

Setup

  1. Have the related FF enabled: echo "Feature.enable(:pipeline_security_dashboard_graphql)" | rails c
  2. You'll need an EE License
  3. You'll need to have runners enabled (See $2408961 for setting up a runner)
  4. Import https://gitlab.com/gitlab-org/govern/demos/sandbox/minac/test-remediations
  5. Run a pipeline on master

Validation

  1. Go to the pipeline's security report tab
  2. Click on an finding with an mr attached to it
  3. Verify that the "MR note" renders as expected

The simplest way to attach a MR to the finding is to disable the feature flag so you have access to the "Create MR" UI. After a MR is created, enable the feature flag to continue the validation steps.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #391741 (closed)

Edited by Samantha Ming

Merge request reports