Skip to content

Convert security sidebar to a panel

Paul Gascou-Vaillancourt requested to merge 391502-sec-sidebar-panel into master

What does this MR do and why?

This rewrites the instance-level Security sidebar using a panel instead of a custom HAML view. This makes it easier for us to support that sidebar in the upcoming super sidebar.

Screenshots or screen recordings

Nav Before After
Current nav Screenshot_2023-02-17_at_4.21.34_PM Screenshot_2023-02-17_at_4.09.52_PM
New nav Same as above Screenshot_2023-02-17_at_4.09.35_PM

How to set up and validate locally

  1. Navigate to the instance security dashboard at /-/security/dashboard.
  2. To enable the new nav:
    1. Enable the feature flag:

      echo "Feature.enable(:super_sidebar_nav)" | rails c
    2. Enable the user setting from the user dropdown:

      Screenshot_2022-12-13_at_1.32.43_PM

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #391502 (closed)

Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading