Skip to content

Add catch to backOff in job log jump to failures

Miranda Fluharty requested to merge add-catch-to-job-log-failure-backoff into master

What does this MR do and why?

This MR adds a catch to a backOff that didn't have one to stop making unnecessary noise in sentry. It also adds a test that throws an error in this spot and expects it to be caught.

From this thread:

this should have a catch, as backoff is throws sentry errors otherwise

stumbled across here: https://new-sentry.gitlab.net/organizations/gitlab/issues/619/?project=4&query=is%3Aunresolved#exception

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

option 1:

  1. git checkout add-catch-to-job-log-failure-backoff
  2. yarn jest spec/frontend/jobs/components/job/job_log_controllers_spec.js

option 2:

  1. git checkout add-catch-to-job-log-failure-backoff
  2. echo "Feature.enable(:job_log_jump_to_failures)" | bundle exec rails console
  3. enable sentry in gdk
  4. throw an error inside the backOff
  5. local sentry should not have received the error

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miranda Fluharty

Merge request reports

Loading