Add catch to backOff in job log jump to failures
What does this MR do and why?
This MR adds a catch
to a backOff
that didn't have one to stop making unnecessary noise in sentry. It also adds a test that throws an error in this spot and expects it to be caught.
From this thread:
this should have a
catch
, asbackoff
is throws sentry errors otherwisestumbled across here: https://new-sentry.gitlab.net/organizations/gitlab/issues/619/?project=4&query=is%3Aunresolved#exception
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
option 1:
git checkout add-catch-to-job-log-failure-backoff
yarn jest spec/frontend/jobs/components/job/job_log_controllers_spec.js
option 2:
git checkout add-catch-to-job-log-failure-backoff
echo "Feature.enable(:job_log_jump_to_failures)" | bundle exec rails console
- enable sentry in gdk
- throw an error inside the
backOff
- local sentry should not have received the error
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Miranda Fluharty