Skip to content

Add optional reason when dismissing vulnerabilities (Dismissal reason: Step Two)

Sam Beckham requested to merge 10364-dismissal-reason-FE into master

What does this MR do?

This is the next step towards completing #10364 (closed)

dismissal-reason

Allows a reason to be provided for a vulnerability dismissal

  • Moves dismissal button into it's own <dismissal-button> component
  • Adds a button grouping with the comment icon
  • Adds a tooltip to the comment button
  • Adds a comment param to the dismissal action
  • Adds new actions/mutations to open/close the dismissal comment box.
  • Adds a <dismissal-comment-box> component
  • Splits out the modal footer into its own component
  • Switches the modal footer when you're typing a dismissal reason
  • Hooks up the dismissal buttons to the new actions
  • Adds the icon for dismissal comments
  • Adds the comment to the modal info (with dummy data)
  • Fills in dismissals in limbo with appropriate dummy content
  • Adds the actions/mutations to the shared reports too
  • Allows comments to be submitted with cmd + enter
  • Autofocuses the comment box on creation
  • Adds an error state for empty comments
  • Everybody gets a test!

CE Backport for styling: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27835/diffs

NOTE: This has been branched off !11028 (merged). We should only merge this into master once !11028 (merged) is merged

Screenshot_2019-04-29_at_18.13.08

Screenshot_2019-04-29_at_18.12.41

Screenshot_2019-04-29_at_18.12.21

Screenshot_2019-04-29_at_17.42.58

Screenshot_2019-04-29_at_17.46.03

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Edited by Sam Beckham

Merge request reports

Loading