Skip to content

Remove feature flag improved_spread_parallel_import

Rodrigo Tomonari requested to merge rodrigo/remove-improved-spread-parallel-import-ff into master

What does this MR do and why?

Removes the feature flag improved_spread_parallel_import and makes the improved_spread_parallel_import the default way to spread jobs in GitHub Import.

The feature flag has been enabled for one month and no one complained about any missing records as used to happen with the previous method. So it is sensible to remove it in the next release.

The only reported problem is https://gitlab.com/gitlab-org/gitlab/-/issues/391834, which started to occur because GitHub Import no longer misses records when the API rate limit is reached.

Related to:

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. Enable GitHub Import in the settings (Admin -> Settings -> General -> Visibility and access controls -> Enable GitHub)
  2. Import a project using GitHub Importer via UI (+ New Project -> Import Project -> GitHub) or API
curl --location --request POST 'http://gdk.test:3000/api/v4/import/github' \
--header 'Authorization: Bearer <GITLAB ACCESS TOKEN>' \
--header 'Content-Type: application/json' \
--data-raw '{
    "personal_access_token": "<GITHUB ACCESS TOKEN>",
    "repo_id": "238972",
    "target_namespace": "root",
    "new_name": "rspec-core",
    "optional_stages": {
        "single_endpoint_issue_events_import": true,
        "single_endpoint_notes_import": true,
        "attachments_import": false
    }
}'
  1. Check if all data was imported

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rodrigo Tomonari

Merge request reports