Skip to content

E2E test: include dropdown module in new mr

Jay McCure requested to merge jmc-fix-dropdown-error-e2e-tests into master

What does this MR do and why?

Test sometimes fails with no method error for search_and_select which is in the dropdown module. Module wasn't previously included, this MR includes the dropdown module.

Example of previous failure: https://gitlab.com/gitlab-org/quality/nightly/-/jobs/3796344320#L2481

Strangely this failure doesn't always occur, however this code path is only exercised in certain circumstances.

How to set up and validate locally

Usually when creating an MR the tests click the following button which jumps to the new MR page. Screenshot_2023-02-10_at_10.40.15

QA_LOG_LEVEL=DEBUG QA_GITLAB_URL=http://192.168.4.31:3000 bundle exec rspec qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_spec.rb However, when this button doesn't appear (when push event isn't published in time) the tests will navigate to the compare branches page.

So to verify this fix locally, we must put a breakpoint here and then manually close the above popup to exercise this flow.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports

Loading