Skip to content

Queue runner version update immediately

Pedro Pombeiro requested to merge pedropombeiro/389230/1-refactor-runner-version-sync into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR irons out the differences between the heartbeat methods of Ci::Runner (the legacy implementation that will be phased out in %17.0) and of Ci::RunnerMachine. It also refactors the specs to avoid redefining subject and to have better contexts.

The only difference in behavior is that we no longer wait until the attributes are written to the database before we queue the Ci::Runners::ProcessRunnerVersionUpdateWorker.

Part of #389230 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

N/A. The behavior change is covered in the specs.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports