Skip to content

Make k8s namespace cleanup method public

David Dieulivol requested to merge ddieulivol-make_ns_cleanup_method_public into master

What does this MR do and why?

Fix tiny bug introduced in !112532 (merged).

This MR fixes errors as seen in https://gitlab.com/gitlab-org/gitlab/-/jobs/3811165709,

scripts/review_apps/automated_cleanup.rb:246:in `delete_helm_releases': private method `delete_namespaces_by_exact_names' called for #<Tooling::KubernetesClient:0x00007f9c53ad0dd0 @namespace="review-apps"> (NoMethodError)
	from scripts/review_apps/automated_cleanup.rb:161:in `perform_helm_releases_cleanup!'
	from scripts/review_apps/automated_cleanup.rb:304:in `block in <main>'
	from scripts/review_apps/automated_cleanup.rb:275:in `timed'
	from scripts/review_apps/automated_cleanup.rb:303:in `<main>'

This call happens when we need to clean up helm releases, which is once a day.

We'll add specs to this class in #392858 (closed).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Dieulivol

Merge request reports