HtmlToMarkdownParser: Clean attributes for more tags
What does this MR do and why?
Previously, we've removed attributes (except for src
and alt
) only
for the <img>
tag.
Now, we are removing for all tags (<em>
, <strong>
, <details>
) we convert to markdown to.
This PR is continuation for this one - !109811 (merged)
Note that this functionality is still behind feature flag. See https://gitlab.com/gitlab-org/gitlab/-/issues/389822+.
Screenshots or screen recordings
Before | Now |
---|---|
How to set up and validate locally
- Download MIRO email example: miro_board.eml
- Update email with your projects email in Service Desk. This one
eyero-ext+flightjs-flight-7-issue-@gitlab.com
- Start local env:
gdk start
- Run
bin/mail_room start
- Run
spring rails c
in gitlab directory.
Then in console:
raw = File.open("miro_board.eml").read
::ServiceDeskEmailReceiverWorker.new.perform(raw)
Go to the project issues and open newly created issue.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #372301 (closed)
Edited by Peter Leitzen