Skip to content

Ensure package-and-test ruby3 flags are inherited

DJ Mountney requested to merge fix-package-test-inherit-vars into master

What does this MR do and why?

Ensure package-and-test ruby3 flags are inherited

  • Only RUBY_VERSION was being passed previously
  • review-apps was on ruby3 but package-and-test was on ruby2
  • Also adds support for the forcing a ruby2 package pipeline

Initially I was trying to update the ruby2 build so that it continued to actually build ruby2 in package-and-test after omnibus-gitlab!6647 (merged) is merged. But during that testing I had a concern where it appears that the master and MR pipelines haven't actually been running ruby3 for e2e-package-and-test . If you look at the trigger-omnibus-env job for the master schedule (example) you can see it hasn't been setting the ruby3_build env.

I believe this fixed that issue. The issue was introduced when we stopped inheriting the top level variables in !111125 (merged)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by DJ Mountney

Merge request reports

Loading