Skip to content

MR metrics refresh worker should fail gracefully

Pavel Shutsin requested to merge 389256-error-budget-analytics-codereviewmetricsworker-failing into master

What does this MR do and why?

Analytics::CodeReviewMetricsWorker sometimes fails when MR was deleted in the middle of CodeReviewMetricsWorker execution. So here we rescue SQL exception and fail gracefully since there is no metrics to update anymore if MR is deleted.\

Second commit just updates fixture compliance to rubocop rules.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #389256 (closed)

Merge request reports