Skip to content

Fix formatting of date for clear status on super sidebar

Doug Stull requested to merge 392870-fix-user-status-super-sidebar-issue into master

What does this MR do and why?

  • Fixes issue with super sidebar for editing user status for Firefox/Safari.
  • DRYs up the fetching of the user status
  • Fixes the AR relationship inference and then fixes the tests to reset the relation since delete is used in blanking the status

note: no changelog since super sidebar is behind a feature flag

Screenshots or screen recordings

on firefox

before after
Screen_Shot_2023-03-01_at_2.37.54_PM Screen_Shot_2023-03-01_at_2.36.49_PM

How to set up and validate locally

  1. Enable the invite modal
    Feature.enable(:super_sidebar_nav)
  2. Enable New navigation toggle under the user dropdown.
  3. Set user status in chrome with a clear after date.
  4. Switch to Firefox.
  5. Go to edit the previously set user status.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #392870 (closed)

Edited by Doug Stull

Merge request reports

Loading