Skip to content

Hide legacy contribution analytics HAML data if feature flag enabled

Rudy Crespo requested to merge 376001-provide-legacy-page-data-if-feature-disabled into master

What does this MR do and why?

As a precursor to !109880 (closed) and the eventual removal of the contribution-analytics-graphql feature flag along with any old code once feature parity is achieved in the transition from HAML to GraphQL for Contribution Analytics, this MR ensures that legacy HAML data is only provided to the Vue app if the feature flag is disabled, which should further improve TTFB on the GraphQL version of the app.

How to set up and validate locally

  1. Feature.enable(:contribution_analytics_graphql, Group.find(GROUP_ID)).
  2. Visit the contribution analytics page for the group you enabled the feature flag ( http://gdk.test:3000/groups/${GROUP_NAME}/-/contribution_analytics), as well another for which the feature flag is disabled.
  3. Validate the charts/table work as expected for both pages.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #376001 (closed)

Edited by Rudy Crespo

Merge request reports