Skip to content

Don't disable license_scanning_sbom_scanner e2e FF

Adam Cohen requested to merge 389906-remove-feature-flag-from-e2e-tests-for-license-management into master

What does this MR do and why?

The qa e2e tests were previously disabling the license_scanning_sbom_scanner feature flag before being run, which was causing the flag to be disabled globally each time the qa e2e tests run. See this thread for more details.

We initially had to disable the feature flag globally to get the qa e2e tests passing, as explained in this comment, however, now that Fallback to License Scanning SBOM Scanner when ... (#384936 - closed) has been completed, we no longer need to disable this feature flag, and the tests will still pass.

This MR is the first part in a two-part plan:

  1. Once we merge this MR, the qa e2e tests will only be testing the legacy Gitlab::LicenseScanning::ArtifactScanner.

    However, the addition of this MR will make it easier for us to continue other work which is currently hindered because the license_scanning_sbom_scanner feature flag is constantly being disabled, as discussed here.

  2. Add qa e2e tests for the new Gitlab::LicenseScanning::SbomScanner class, to be completed shortly in a follow-up MR.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #389906 (closed)

Merge request reports