Skip to content

Fix bug where multiple copy code buttons could exist

Phil Hughes requested to merge ph/388125/fixMultipleCopyCodeButtons into master

What does this MR do and why?

This fixes a bug where sometimes the copy code button on merge request diffs could get duplicated. This is caused by the virtual scroller on diffs which moves elements around and causes the connectedCallback callback method to be called multiple times.

To fix this we simply check if a button exists, if it does then we don't do anything else.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

#388125 (closed)

Merge request reports

Loading