Skip to content

Bypass update of contacted_at on runner /verify endpoint

Pedro Pombeiro requested to merge pedropombeiro/394749/bypass-contacted_at-update-in-verify into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR makes a slight change to the logic of the POST /runners/verify endpoint so that it doesn't set the contacted_at field of the ci_runners record, when the runner being verified has been created from the GitLab UI (using a glrt- prefixed runner token). This is needed so that the GitLab UI can tell when the runner starts to accept jobs (at which point it will update the contacted_at field).

Part of gitlab-runner#29665 (closed)

Closes #394749 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Since this MR is hard to reproduce due to the need for an updated gitlab-runner, I've recorded a video demoing the branch: https://www.loom.com/share/b0f77084fd704458990290ea2340c78c

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports