Skip to content

Draft: Convert groups.scss into a page specfic bundle and cleanup some unused CSS

What does this MR do and why?

Moves stylesheets/pages/groups.scss to page_bundles/groups.scss CSS and cleans up some unused CSS.

Screenshots

Before After
Dashboard/Groups Screenshot_2023-03-10_at_13.04.15 Screenshot_2023-03-10_at_13.05.39
Explore/Groups Screenshot_2023-03-10_at_13.04.20 Screenshot_2023-03-10_at_13.05.39

How to set up and validate locally

Most of the CSS in groups.scss is related to the list display of groups. You can validate those changes by visiting:

  1. Your work > groups
  2. Clicking the Your groups tab and explore tab

This file also contains CSS for this element: badge. Which is scattered around the product. You can validate that this is displaying correctly by visiting:

  1. dashboard/projects (Yours, starred, explore) on your dashboard
  2. dashboard/groups
  3. ...
Screenshots of the user access badge

Screenshot_2023-03-10_at_16.37.51

Screenshot_2023-03-10_at_16.37.51

And finally this file contains CSS to style an input group in the settings. This only affects the visuals if there is a long URL so the simplest way to verify is that the CSS is applied to the .group-root-path element

Numbered steps to set up and validate the change are strongly suggested.

<!114285 (merged) -- Example below:

  1. Enable the invite modal
    Feature.enable(:invite_members_group_modal)
  2. In rails console enable the experiment fully
    Feature.enable(:member_areas_of_focus)
  3. Visit any group or project member pages such as http://127.0.0.1:3000/groups/flightjs/-/group_members
  4. Click the invite members button. -->

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #239833

Merge request reports

Loading