Skip to content

Revamp API::Internal::Pages specs

Kassio Borges requested to merge kassio/revamp-pages-api-specs into master

What does this MR do and why?

⚠ depends on Add gitlab-pages unique url lookup (!109891 - merged)

Related to: Follow-up from "Add gitlab-pages unique url loo... (#396139 - closed)

  • Use let_it_be for complex models used in the tests
  • Remove outdated spec
  • Remove methods that abstracted too little adding too much indirection

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kassio Borges

Merge request reports