Skip to content

Enable auto-disabling failed hooks feature for Group Webhooks

Luke Duncalfe requested to merge 385902-apply-autodisabling-webhooks-to-group-hooks into master

What does this MR do and why?

This change applies the auto-disabling of failed webhooks feature to group hooks.

How to set up and validate locally

  1. Enable the auto-disabling webhook feature 
    Feature.enable(:auto_disabling_web_hooks)
  2. Create a group webhook:
    1. Choose a group, go Settings > Webhooks.
    2. For URL enter https://httpstat.us/500 which will return a 500 error response.
    3. For Trigger, select Issues events.
    4. Click Add webhook.
  3. Go Issues > List and choose and issue.
    1. Close, reopen, close, reopen, close and reopen the issue to generate lots of webhook triggers.
  4. View the group webhook again Settings > Webhooks scroll down to your hook and click Edit. You should see the below banner:
  5. Close, reopen, close etc. the issue and it should not generate any further Recent events for the webhook until it reenables.

image

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #385902 (closed)

Edited by Luke Duncalfe

Merge request reports