Skip to content

Add complexity and gitaly flag against suggest_approvers field

Sincheol (David) Kim requested to merge add-complexity-call-gitaly-to-approval-state-type into master

What does this MR do and why?

I noticed we don't have calls_gitaly flag set against suggest_approvers field while investigating related issue. It can trigger gitaly calls when it filters committers and it will raise exception in development environment.

It's not necessary, but I've also added complexity: 10 as it utilizes wrapped_approval_rules and committers which are defined as complexity: 5.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sincheol (David) Kim

Merge request reports