Skip to content

Fix accidental code removal (application secret)

Eduardo Sanz García requested to merge eduardosanz/reenable-renew-application-secret into master

What does this MR do and why?

The renewal of the application OAuth secret was introduced recently: Allow user/admin/group to generate a new applic... (!106164 - merged)

During the removal of the hash_oauth_secrets feature flag, Remove hash_oauth_secrets feature flag (!113892 - merged), accidentally the render function was removed.

The mistakenly removal happened because the render function was very close to the code removed.

Screenshots or screen recordings

N/A

How to set up and validate locally

  1. Create an application here: https://gdk.test:3443/oauth/applications (Name: blah, Redirect URI: app://, Scopes: any)
  2. Reload the page and you should see the Renew secret button:

image

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Sanz García

Merge request reports