Skip to content

Geo - Remove temporary multiversion support

Zack Cuddy requested to merge 396730-remove-tem-geo-multiversion-support into master

What does this MR do and why?

Closes #396730 (closed)
Cleans up technical debt intentionally introduced in #393925 (closed)

This MR is a result of my misunderstanding of Backwards Compatibility in JavaScript.

The short explanation is that I had thought when updating the link between HAML / JS (ie. Data Attributes), we would need the Frontend Bundle to support the possibility of the FE bundle deploying before the BE bundle which would cause a disconnect between the two files where the BE referenced the old code (ie. old Data Attributes) and the FE referenced the new code.

To solve this, I felt temporarily having the FE support both HAML file possibilities seems straight forward.

Long Explanation: !113771 (comment 1305435081)


As it turns out this was not needed at all but it didn't hurt anything. This MR is simply removing that duplication as it is and was not needed.

Screenshots or screen recordings

No visual changes

How to set up and validate locally

  1. Fetch and checkout this branch
  2. Setup Geo (How to setup Geo)
  3. Access your GDKs
  4. Navigate around the Geo Application (admin/geo)
  5. Ensure everything still works

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #396730 (closed)

Edited by Zack Cuddy

Merge request reports

Loading