Skip to content

E2E: Fix Group audit log specs and update filter_group wait logic

Sanad Liaquat requested to merge qa-shl-fix-group-audit-log-specs into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Related to #396908 (closed)

Fix Govern Group for add group behaves like audit event logs audit events for UI operations spec.

When a group has multiple subgroups, the newly added sub-group is not guaranteed to be on the first page. This MR adds code to search for the group.

It also updates the filter_group to wait for the spinner first before calling wait_for_requests. The reason is that the spinner doesn't appears on the page right away and the has_no_css? used in finished_loading? will return true as soon as it doesn't find the spinner. As a result, the code moves on without actually waiting for the spinner to go away.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sanad Liaquat

Merge request reports

Loading