Fix `Remember me` omniauth
What does this MR do and why?
In the sign-in page, the ID of the Remember me
checkbox element was duplicated. The same
ID, remember_me
, was used for the main login (upper section) and the omniauth
logins (lower section). This created a couple of undesired side-effects:
- Selecting on the lower
Remember me
checkbox, checked the upper checkbox (main login). - More importantly, the
Remember me
was broken because it didn't add the parameterremember_me=1
to theaction
path of the form surrounding the ommiauth logins.
This commit fixes the issue by replacing the remember_me
ID to a more
specific name, remember_me_omniauth
, for the omniauth logins.
Closes #385419 (closed)
Screenshots or screen recordings
N/A
How to set up and validate locally
- Enable LDAP login: https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/ldap.md
- Go to the sign-in page: https://gdk.test:3443/users/sign_in
- Toggle the lower
Remember me
checkbox. - The upper
Remember me
checkbox should remain unchecked. - A
remember_me=1
parameter should be added to the<form>
's action attribute connected to the omniauth buttons.
Screen_Recording_2023-03-21_at_12.05.27
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Eduardo Sanz García