Pass sign-in page path to Web IDE
What does this MR do and why?
It passes the sign in page URL to the Web IDE. The Web IDE uses this URL when displaying an error message that indicates the user is unauthenticated.
Screenshots or screen recordings
How to set up and validate locally
- Install a temporary package that contains the Web IDE updates to handle unauthenticated HTTP errors. This package was generated using the following CI job: https://gitlab.com/gitlab-org/gitlab-web-ide/-/jobs/3949387730
diff --git a/package.json b/package.json index f9299d664108..f395aca820ed 100644 --- a/package.json +++ b/package.json @@ -58,7 +58,7 @@ "@gitlab/svgs": "3.26.0", "@gitlab/ui": "58.2.0", "@gitlab/visual-review-tools": "1.7.3", - "@gitlab/web-ide": "0.0.1-dev-20230223005157", + "@gitlab/web-ide": "https://gitlab.com/gitlab-org/gitlab-web-ide/-/jobs/3949387730/artifacts/raw/tmp/packages/gitlab-web-ide-0.0.1-dev-20230320184121.tgz", "@mattiasbuelens/web-streams-adapter": "^0.1.0", "@rails/actioncable": "6.1.4-7", "@rails/ujs": "6.1.4-7", diff --git a/yarn.lock b/yarn.lock index db5f1a23fd85..9b3035cc2cf1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1256,10 +1256,9 @@ resolved "https://registry.yarnpkg.com/@gitlab/visual-review-tools/-/visual-review-tools-1.7.3.tgz#9ea641146436da388ffbad25d7f2abe0df52c235" integrity sha512-NMV++7Ew1FSBDN1xiZaauU9tfeSfgDHcOLpn+8bGpP+O5orUPm2Eu66R5eC5gkjBPaXosNAxNWtriee+aFk4+g== -"@gitlab/web-ide@0.0.1-dev-20230223005157": - version "0.0.1-dev-20230223005157" - resolved "https://registry.yarnpkg.com/@gitlab/web-ide/-/web-ide-0.0.1-dev-20230223005157.tgz#e8ef36229dbe25bbfccfc57d5f02cce0c94b53c5" - integrity sha512-JLSIC/elod3txZL6CPe6hk07a97VAMjv+DmAvQFAJ/W/cj2wE+AG/ztr/brX2O88Cf4dX4nh48s1n49efMlajQ== +"@gitlab/web-ide@https://gitlab.com/gitlab-org/gitlab-web-ide/-/jobs/3949387730/artifacts/raw/tmp/packages/gitlab-web-ide-0.0.1-dev-20230320184121.tgz": + version "0.0.1-dev-20230320184121" + resolved "https://gitlab.com/gitlab-org/gitlab-web-ide/-/jobs/3949387730/artifacts/raw/tmp/packages/gitlab-web-ide-0.0.1-dev-20230320184121.tgz#497e6496dd230e898ca6d8d7e15c27dacb05ff64" "@graphql-eslint/eslint-plugin@3.16.1": version "3.16.1"
- Open a project in the Web IDE (make sure the "Use legacy web ide" user preference is turned off).
- Open the GitLab application in another web browser tab and sign out.
- Go back to the Web IDE local tab and change a file.
- Try committing the change.
- The Web IDE will display an error message indicating that your session has expired. The Error message also contains a "Sign in" button.
- The sign in button will open the Sign In page in a new tab.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Enrique Alcántara