Skip to content

Set DRY_RUN to false if not set

David Dieulivol requested to merge ddieulivol-fix_automated_cleanup_dry_run into master

What does this MR do and why?

!112690 (merged) introduced a bug when the DRY_RUN env variable isn't set (e.g. https://gitlab.com/gitlab-org/gitlab/-/jobs/3972903306):

$ scripts/review_apps/automated_cleanup.rb --dry-run="${DRY_RUN}" || (scripts/slack review-apps-monitoring "☠️ \`${CI_JOB_NAME}\` failed! ☠️ See ${CI_JOB_URL} - <https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/blob/main/runbooks/review-apps.md#review-cleanup-job-failed|📗 RUNBOOK 📕>" warning "GitLab Bot" && exit 1);
scripts/review_apps/automated_cleanup.rb:295:in `<main>': invalid argument: --dry-run= (OptionParser::InvalidArgument)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Dieulivol

Merge request reports

Loading