Skip to content

E2E tests: don't wait for spinner before clicking diffs tab

Jay McCure requested to merge jmc-click-diffs-tab-immediately into master

What does this MR do and why?

Due to diffs being loaded asynchronously there are a number of bugs that occurring when running the E2E tests, these failures are difficult/impossible to recreate manually and are due to the speed of the automated tests.

One of the issues is #398584 (closed)

This is causing #397657 (closed) to fail consistently in the large setup job.

This MR is to workaround the issue to reduce the failure noise, I have put the issue in a comment so we can remove this if this issue ever gets fixed. We now click the Changes tab even if there is a spinner.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

The issue only occurs in the master pipeline.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports