Skip to content

Confirmation dialog when leaving registration page

What does this MR do and why?

This change attempts to prevent users from leaving the registration page when runner is not yet online.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Enable the feature flag: in your console rails c, and then Feature.enable(:create_runner_workflow_for_admin)
  2. Follow the runner creation instructions from http://gdk.test:3000/admin/runners
  3. Submit the runner form
  4. In the registration page, try to leave the page by clicking on "Go to runners page"
    • browsers will show the confirmation dialog after users interacted with the page, you may try other methods to leave.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #396895 (closed)

Edited by Miguel Rincon

Merge request reports

Loading