Skip to content

Tighten up over limit notification items

Doug Stull requested to merge tighten-up-free-user-cap-notification-items into master

What does this MR do and why?

  • centralizes on naming of namespace and root_namespace as used in other free user cap classes
  • removes Group(s) in naming of services as a way to use convention over configuration due to namespaceing of the services already being under namespace
  • uses(and adds on one) ServiceError error class in services
  • uses the attr_reader in service classes when defined and scopes to private
  • moves methods to private that didn't need to be in the public surface area - for clarity and narrowing public surface area
  • tightens up specs a bit for clarity and reduction of factory creation

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Doug Stull

Merge request reports