Skip to content

Reduce spacing of tertiary buttons in the user bar

Dan MH requested to merge 396689-impersonate-super-sidebar-draft-danmh into master

What does this MR do and why?

Describe in detail what your merge request does and why.

  • The design spec for the super side bar has 0 gap between the tertiary buttons.
  • In addition to matching the spec, this change would allow us room to add an additional button, and simultaneously display the GitLab Next badge in this area.

Work to add an impersonation button is documented in #396689 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-03-22_at_17.20.56 Screenshot_2023-03-22_at_17.20.35

Faking GitLab Next:

Before After
Screenshot_2023-03-22_at_17.40.13 Screenshot_2023-03-22_at_17.39.48

Spacing of elements

Before After
Screenshot_2023-03-27_at_8.37.30_AM Screenshot_2023-03-27_at_10.40.23_AM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable the feature flag:
echo "Feature.enable(:super_sidebar_nav)" | rails c
  1. To check the Next badge, comment out L77.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #396689 (closed)

Edited by Dan MH

Merge request reports

Loading