Reduce trials controller to 2 actions and use Services to drive logic
What does this MR do and why?
Furthers the goals of #393969 (closed) - see there for more detail.
- renames
create_lead
tocreate
- moves functionality of
apply
tocreate
- removes
select
action in favor of redirecting tonew
action with atrial
step - moves to a pure 2 step form setup
Screenshots or screen recordings
no change.
How to set up and validate locally
note basically trying to emulate feature spec steps in ee/spec/features/trials/saas/*
- Setup to simulate SaaS and restart GDK
- Create 2 new groups.
- Visit trials new path as in
http://gdk.test:3000/-/trials/new
. - Fill out the form...
- The rest would be really hard to emulate here w/o a fully setup local customersDot and is why we have the feature specs that haven't needed to change with this MR.
- Namespace selection can be simulated by visiting
http://gdk.test:3000/-/trials/new?step=trial
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #393969 (closed)
Edited by Doug Stull