Skip to content

Support flamegraph for every GET request in the performance bar

Roy Zwambag requested to merge 352726-flamegraph-for-each-dropdown-item into master

What does this MR do and why?

Currently the Flamegraph links are static links that only generate a flamegraph for the initial page load GET request. With this MR we allow every GET request in the Performance Bar dropdown. This MR also adds the HTTP verb to the dropdown, so you can see which requests are GET requests (flamegraph-able), and which are POST (not yet flamegraph-able)

It will also hide the Flamegraph buttons for POST requests as that is not yet supported and could cause confusion. This is the first MR in a series of improvements to the flamegraph feature of the PB. In a followup iteration we want to allow to create flamegraphs for POST requests as well.

Screenshots or screen recordings

Screenshots

Before

Screenshot_2023-03-29_at_14.30.41.

After

Screenshot_2023-03-29_at_14.31.22

Video

Screen_Recording_2023-03-29_at_14.34.04

How to set up and validate locally

  1. Checkout this MR
  2. Open the performance bar by pressing p+b
  3. Click on any flamegraph mode and assert it is a flamegraph of the initial request
  4. Change the request in the dropdown to any other GET request
  5. Click on any flamegraph mode and assert it is a flamegraph of the selected request
  6. Click on any POST request and assert the flamegraph buttons are not visible

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #352726 (closed)

Edited by Roy Zwambag

Merge request reports