Fix reconcile needed warning for offline license
What does this MR do and why?
Fix customers-gitlab-com#6027 (closed)
Fix reconcile needed warning for offline license
Display banner only if seat reconciliation is turned on.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
I first changed the following line for the ease of testing: https://gitlab.com/gitlab-org/gitlab/blob/d104a3014ece2370044725cda76a60f8ad03c70f/ee/app/helpers/manual_quarterly_co_term_banner_helper.rb#L7-7
upcoming_reconciliation = GitlabSubscriptions::UpcomingReconciliation.new(next_reconciliation_date: Date.current)
I created a new License which is offline and seat reconciliation enabled:
data = "eyJkYXRhIjoiZzR5Nk1zZW8xdklPckRRTWhmZUhURHZPa2JWckYreTdrOENB\nb1ljNFZqSE9LZE5tLzQxekFxMDhKUTVKXG4ya0hoVDhuMkRHanU3VkFERndF\nWE16dVZ1YmlNc1BZSTRsZ1k4Qi84UlFsRjdKWkJxU2VSLzNKWlNycm5cbnQw\nWnZCSUg4cFgyUW0yNlVFbUt2cnArYUpmRUtuQWVXdUJhU29TNTFIRndFUUYv\nbnIzb2RjNDQrQXNPYVxuMkx4c1VKVUdVbEhYSHl2T2xYejI1VVhDemxtY3FE\nMEFadkxZM0pKdmFXM011enhXMUw1VTJ2QVRKOWRIXG43WFhxQnNDODZtWFZS\na0dKR2pHQ3dnWHBHa0tFS0FhQ0lWeWxVVFIzMVA0K2Q4blB4c00rVVJBVGhL\ncnlcblA1RzN3UzRtR0llWUpWR1hsbU1vMllXeFp4MTZVenc3RTIrcmZXaDQx\nUFFIK0g2aXRTWUVzNnp6UG1KaVxuRVRZVHdQNnM4cGFheWg1MVhOWjhwanlZ\nclM4MVZNRTZ3QnNjUEEzRXpGdFNsNlZTclBSazI1U3M1eHRvXG5nU3plUk5n\nRmFQYVFSOUMza1RvWkFjNENTS3hFcExmL0tJZ3JJOW5qU2tMdkZ6bjdVNmN0\nMUhvUGt6QlJcbktxQ1hIV1Y0bG9UVFhmQmhpamZUUnNseFFPNElaWmh2eDhz\nNlp6RHN0RHU5cHNSSzhHc0EvUkJ6MUhOMlxuNDJManlUWXJmY3YvUnNLRC9r\nbzNWdmNjSHVVb3pBNzJkU1RoWkxjK0JkczVTR1YxNXFCZ1ZHTE5lc2o4XG5T\nVFd1c0JLdkprQ1dUaTNLQlU5cXd6LzJhT1hoZ1pJdVk5TEt2bkJ2S2UyTFcr\ncmJqV2k5T2l1eXc5MG5cbjBWYjFKWmV0ZkFWKzF4bVdlQ0tMUytxclFZYUlF\nY1JnY2JNZ2RFVEJ6Z1hIZ3pLa2J6OWRKaytadUFsdVxuL1VFSGxXRFUxMmtw\nYWg3dm45bmx3UE1tTzhiNlJIMW9MUkY2SXdWb0pLQVh4VTBhTlI4K3UralJW\ncThpXG43OTlKQnNNSU9yclh2M2ZZUnZGSk00dzJ0MS9oYU9CN3ZwcVdmVzVr\ncE5ZNWhheFM2c3pPNzk2MWZ5WlRcbmVkdUdVOHA3UGV1S2dncXlISklMSnJD\nanJaOWVvenRhUXE0bFR2MWtTTzF6djBoMk5zNFNPeEZZNWE3MFxuTUkyZG1o\nYXhYalhjblVxYVlMak1xVHFSK0J4NnBTanJKL28razlKeWsvNnhmY0VuSmYw\nRGJLczVGVXlGXG42Zy9PYUlEall5K3FPbDhBTnVDV1hUTTJ1YlhJVXpyN3dy\nR29aNnJ0ZENCTUFjZStkZ25vcDJ4UmMrODBcbkhybDRlTmdNM3lPRnVhUE0z\na2kvUnZzakJ3WHgyM3R3MlpxeFVxMnBBMzcrc21DQkdBTkdkMjVLaERJMFxu\nVUdydS92dUgxL3o0Y1hWOXlOcVEvMVh4V3QwZzUvbDUxaC9LSlNyZDAxdWx2\nazR1UkJMMnpnTk91YzFQXG54Zk52ZGZyR0NOSEZ1M003U1Z1NTRXTU96SU9J\naHZ4TFhBPT1cbiIsImtleSI6IkZpRGNCRW5sWCtDdGFRUzZtSDAweEZRNHVX\nNkpYM0FTN2FkanZHWFJCVVVpbGhlMEp0emNJamZ4ejhsZlxudXdaZVpUaE5S\nMS9oSUtkTlNwaCs2MGc0TE5MS0RwRU1UQThwSFM5SUlkejZndGx6K1hqa0Vo\nWVo4Rk12XG50UWFLeWR3Zi9raHZRSWpWOGczOXRhbnA4VWVGMEhUd3lQb1Mx\nZi9kOGJtQkt6YitoRHc1dUtkNlJibTBcblA0dnZwTjFEU2NqSXBUaWZadHY3\nL2JQV1hkb0ZzN2JxbnVLeVNTM2pYQWtIMUhYVUtmMG1wZ1diSUt0b1xucGVM\nSUVoYzZSdjJQUS9iNk1UbXM1RDFJeDltVUVTTFAzbFRkSVk1N1RLQUx5VVVs\nUEtkR1RRMUR3SW1NXG5uVlcyU3dSaURhSXFJcElEK2JXTnpiMlpldGo0bjZu\nRmtLekF6WXhUZUE9PVxuIiwiaXYiOiIxdG5HQm1sL3ZPSFRIeDd6eUtvbmFB\nPT1cbiJ9\n"
License.create!(data: license_key, cloud: true, last_synced_at: Time.current)
Then login to admin dashboard.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Mark Chao