Skip to content

Fix incorrect value stream analytics FF check

Adam Hegyi requested to merge ah-fix-incorrect-vsa-ff-check into master

What does this MR do and why?

This MR fixes the stuck group-level VSA page: #403637 (closed)

Problem: we reused the group-level UI on the project-level and put it behind a FF. When checking for the feature flag, we forgot to check if we're visiting a project thus page seems "disabled" on the group-level. The FF should only apply on the project-level.

Fix: move the FF check where we check the license for the project.

How to set up and validate locally

  1. Ensure you're on premium or ultimate
  2. Open the group-level VSA page: Analytics -> Value Stream
  3. Create a value stream with a stage.
  4. Run in rails console: Analytics::CycleAnalytics::IncrementalWorker.new.perform
  5. Refresh the VSA page. The empty VSA page (with 0 counts) should show up.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Adam Hegyi

Merge request reports

Loading