"a245b5bb" did not exist on "master"
Update nav sidebar use height variables for fixed position
What does this MR do and why?
!114984 (merged) introduces new $calc-application-header-height
, $calc-application-footer-height
, and $calc-application-viewport-height
variables which use calc()
to calculate heights based on the conditional presence of system header, system footer, performance bar, and header.
These changes apply $calc-application-header-height
and $calc-application-footer-height
to the fixed nav-sidebar.
Screenshots or screen recordings
Variant | Screenshot |
---|---|
All | |
Sticky header | |
Sticky footer | |
Performance bar | |
None |
How to set up and validate locally
- Enable system header/footer messages in admin settings
- Toggle the performance bar with p + b
- Visit any page with nav-sidebar
- Ensure
top
/bottom
position is correct
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #403579 (closed)