Release a bug fix for the Maven package registry upload endpoint
Context
In %15.11, we looked at 3 issues related with the upload endpoint in the Maven Repository:
- Maven sha1 file race condition (404 error) (#362665 - closed). Here, we knew that a replica lag was the root cause.
- Maven package creation race condition (400 error) (#362668 - closed). Here, after some investigation, it was discovered that the replica lag was also the root cause.
- Maven package registry returning 409 when uploa... (#367356 - closed). While testing locally the fix for the replica lag, we stumbled upon this situation.
The fix here was simple: force the use of the primary database. Look at !115053 (merged) for more detailed context.
Since the Maven Repository is used massively on gitlab.com, the fix was deployed using a feature flag.
Rollout issue: #397028 (closed). At the time of this writing, the feature flag has been enabled for 4 days.
After a few days, the observations are the following:
-
404
and400
withName already taken
completely gone.-
404
: https://log.gprd.gitlab.net/goto/12158f70-d221-11ed-a017-0d32180b1390 -
400
withName already taken
: https://log.gprd.gitlab.net/goto/1e08f290-d221-11ed-a017-0d32180b1390
-
- Situation has improved for
409
responses.- See https://log.gprd.gitlab.net/goto/a1729c30-d221-11ed-a017-0d32180b1390.
- We will need to investigate more for this case.
All in all, the fix is completely fixing 2 issues and helping with the situation for another issue. As such, it is still valuable to release this fix by removing this feature flag. That's what this MR does.
🔍 What does this MR do and why?
- Remove the
packages_registry_maven_uploads_force_primary
feature flag. - Update the related specs.
🖼 Screenshots or screen recordings
None
⚗ How to set up and validate locally
See !115053 (merged), section With the feature flag enabled
.
🚥 MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.