Skip to content

Release a bug fix for the Maven package registry upload endpoint

David Fernandez requested to merge 397028-cleanup-feature-flag into master

Context

In %15.11, we looked at 3 issues related with the upload endpoint in the Maven Repository:

  1. Maven sha1 file race condition (404 error) (#362665 - closed). Here, we knew that a replica lag was the root cause.
  2. Maven package creation race condition (400 error) (#362668 - closed). Here, after some investigation, it was discovered that the replica lag was also the root cause.
  3. Maven package registry returning 409 when uploa... (#367356 - closed). While testing locally the fix for the replica lag, we stumbled upon this situation.

The fix here was simple: force the use of the primary database. Look at !115053 (merged) for more detailed context.

Since the Maven Repository is used massively on gitlab.com, the fix was deployed using a feature flag.

Rollout issue: #397028 (closed). At the time of this writing, the feature flag has been enabled for 4 days.

After a few days, the observations are the following:

  1. 404 and 400 with Name already taken completely gone.
  2. Situation has improved for 409 responses.

All in all, the fix is completely fixing 2 issues and helping with the situation for another issue. As such, it is still valuable to release this fix by removing this feature flag. That's what this MR does.

🔍 What does this MR do and why?

  • Remove the packages_registry_maven_uploads_force_primary feature flag.
  • Update the related specs.

🖼 Screenshots or screen recordings

None

⚗ How to set up and validate locally

See !115053 (merged), section With the feature flag enabled.

🚥 MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Fernandez

Merge request reports