Skip to content

Fix regression with 'waiting_for_events' state

Allen Cook requested to merge 403038-reflect-errors-in-productanalyticsstate-graphql-query into master

What does this MR do and why?

In the fix for returning a Cube API error state correctly, the check for 'waiting_for_events' due to a missing DB was broken. This also exposed a missing unit test for this condition

Screenshots or screen recordings

query {
  project(fullPath: "gitlab-org/gitlab-shell") {
    name
    productAnalyticsState
  }
}
{
  "data": {
    "project": {
      "name": "Gitlab Shell",
      "productAnalyticsState": "WAITING_FOR_EVENTS"
    }
  }
}

How to set up and validate locally

  1. Follow the steps to setup the product analytics devkit but do not feed it any event data
  2. productAnalyticsState should be waiting_for_events with no errors

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #403038 (closed)

Edited by Allen Cook

Merge request reports