Fix regression with 'waiting_for_events' state
What does this MR do and why?
In the fix for returning a Cube API error state correctly, the check for 'waiting_for_events' due to a missing DB was broken. This also exposed a missing unit test for this condition
Screenshots or screen recordings
query {
project(fullPath: "gitlab-org/gitlab-shell") {
name
productAnalyticsState
}
}
{
"data": {
"project": {
"name": "Gitlab Shell",
"productAnalyticsState": "WAITING_FOR_EVENTS"
}
}
}
How to set up and validate locally
- Follow the steps to setup the product analytics devkit but do not feed it any event data
-
productAnalyticsState
should bewaiting_for_events
with no errors
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #403038 (closed)
Edited by Allen Cook