Skip to content

Remove product_category from the EE metrics

Niko Belokolodov requested to merge 393366-remove-product_category-from-metrics-yml into master

What does this MR do and why?

This MR contains a lot of files, but they all are metric configs and all have 1 line removed (product_category: \w+).

Reason

When setting up a new metric the documentation suggests to add a product_category from the categories.yml.

These categories, however do not map to very general metrics, such as hostname, uuid or [license_billable_users](https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/config/metrics/license/20210531204603_license_billable_users.yml). Currently, these metrics use a product_category called collection, which is not part of categories.yml.

We discovered that product_category is not really used right now anyway (see #393366 (comment 1295122962), #393366 (comment 1295377452)). Adding the product_category is an effort every time a metric is created.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #393366 (closed)

Edited by Niko Belokolodov

Merge request reports