Add focus background and margin-bottom to super sidebar nav items
What does this MR do and why?
Add focus background and margin-bottom to super sidebar nav items
- Update
@gitlab/ui
to v59.1.0 forgl-focus-bg-t-gray-a-08
class - Add
gl-mb-1
andgl-focus-bg-t-gray-a-08
classes - Add
gl-focus-bg-t-gray-a-08
class to context-switcher and pin toggle
Screenshots or screen recordings
Before | After |
---|---|
CleanShot_2023-04-05_at_15.41.19 | CleanShot_2023-04-05_at_15.41.51 |
- Hover: "Code"
- Active: "Repository"
- Focus: "Branches"
Video comparison between before and after
CleanShot_2023-04-05_at_15.16.46
How to set up and validate locally
- Enable super sidebar (if not currently on)
- In
rails c
enable feature flagFeature.enable(:super_sidebar_nav)
- Toggle on "new navigation" in user menu
- In
- Compare
:hover
/:focus
and current page styles
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Scott de Jonge