Skip to content

Do not throw on props validation in tests

Illya Klymov requested to merge xanf-fix-bad-console into master

What does this MR do and why?

Related issue: Fix incorrect console handling in Jest tests (#396779)

In our tests we've decided to implement console.warn / console.error throwing on invocation

no-michael-nono__1_

Throwing results in so many differences in behavior between tests and real world components, that this is impossible to fix in one MR

This MR is focusing solely on three things:

  • intoducing new assertProps helper for testing props
  • replacing previous prop testing with assertProps
  • making console.error for Vue props validation go through so developers are aware of them when writing tests

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

N/A

How to set up and validate locally

  • 🍏 green pipeline = 🏎

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Illya Klymov

Merge request reports

Loading