Add standalone modal to current pipeline report (behind feature flag)
requested to merge 404756-add-standalone-modal-to-current-pipeline-report-behind-feature-flag into master
What does this MR do and why?
- Adds new feature flag:
standalone_finding_modal
- Renders standalone finding modal behind feature flag on pipeline security report
Screenshots or screen recordings
Screen_Recording_2023-04-11_at_2.56.54_pm
How to set up and validate locally
Setup
- You'll need an EE License
- You'll need to have runners enabled (See $2408961 for setting up a runner)
- Import https://gitlab.com/svedova/test-remediations-v2
- Run a pipeline on master
You will also need to enable two feature flags:
echo "Feature.enable(:deprecate_vulnerabilities_feedback)" | rails c
echo "Feature.enable(:standalone_finding_modal)" | rails c
Validation
- Go to the pipeline's security report tab
- Click on a finding
- Dismiss the finding
- Click "Undo dismiss" on the toast message - verify finding is not dismissed
- Dismiss finding again - verify finding is dismissed
- Toggle "hide dismissed" to be off
- Revert dismissal from the report
- Dismiss finding with a comment - verify that the finding renders as dismissed and with a comment within the report
- Delete the comment - verify that the finding only renders as dismissed and with no comment
- Revert dismissal - verify that the finding is no longer dismissed
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #404756 (closed)
Edited by Samantha Ming