Skip to content

Ensure that super sidebar becomes visible on resize

Paul Gascou-Vaillancourt requested to merge 404903-invisible-sidebar into master

What does this MR do and why?

This fixes a change that caused the sidebar to remain invisible when loading a page with a viewport narrow-enough for it to start collapsed, then expanded the window until the super sidebar attempted to slide in.

Also refactors the related spec to remove some logic from the test-case, which should make the scenarios easier to grasp.

Screenshots or screen recordings

Before After
ghost noghost

How to set up and validate locally

  1. Enable the new nav:

    1. Enable the feature flag:

      echo "Feature.enable(:super_sidebar_nav)" | rails c

    2. Enable the user setting from the user dropdown:

      Screenshot_2022-12-13_at_1.32.43_PM

  2. If you have previously collapsed the sidebar manually, make sure to expand it once.
  3. Reduce the window until the sidebar automatically slides out.
  4. Reload the page.
  5. Expand the window until the sidebar slides in.
    • The sidebar should be fully visible.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #404903 (closed)

Merge request reports