Move frontend ~/artifacts to ~/ci/artifacts
What does this MR do and why?
For verify-stage#426 (closed), verify-stage#422 (closed), #393864 (closed)
We want to require verify domain expert approval to changes to the artifacts page javascript/vue code, so it needs to be covered by the [Verify]
rules in our CODEOWNERS
file. We can do this by moving this code into a ci
subfolder to make it match the /**/app/**/ci/
pattern.
Screenshots or screen recordings
No UI changes are expected
How to set up and validate locally
echo "Feature.enable(:artifacts_management_page)" | bundle exec rails console
git checkout move-artifacts-app-directory-inside-ci-directory
- navigate to a project, and in the sidebar select
CI/CD
=>Artifacts
- artifacts from the project's pipelines should appear as normal
to see this page in the review app
If the review app has been stopped by the time you're doing this:
- retry the
start-review-app-pipeline
job to start it again - if you don't see the
Artifacts
link in the sidebar, enable theartifacts_management_page
feature flag in the review app environment (see Enable a feature flag for my review app)
to run tests
-
bundle exec rspec spec/frontend/fixtures/job_artifacts.rb
to generate the graphql fixture -
yarn jest artifacts
to run all artifacts jest tests
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Miranda Fluharty