Skip to content

Adjusts param handling in namespace API

Vijay Hawoldar requested to merge vij-shared_runners_param into master

What does this MR do and why?

When a subscription expires, we sync the expired order from CustomersDot to GitLab, to let GitLab.com know that the subscription has expired and ensure the two platforms are in sync.

This sync hits the namespaces REST API to update the namespace with the relevant info, e.g. the plan the namespace is now on.

Currently, this does not reset the monthly allocation of minutes to the plan limits defined in GitLab (e.g. 400 minutes/month for free plan).

This is the second step to rectify that problem:

  1. In CustomersDot we will send shared_runners_minutes_limit: nil, whereas before we would not send this param - handled in https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/7033
  2. In GitLab (this MR), we will modify this conditional to check for the param key, which will in turn trigger the reset of the minutes to the pre-defined values via the Ci::Minutes::RefreshCachedDataService

Refs https://gitlab.com/gitlab-org/gitlab/-/issues/297026#note_1072579509

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vijay Hawoldar

Merge request reports