Skip to content

Add ability to create (GitLab) issue from new finding modal

David Pisek requested to merge 393376-render-create-issue-gitlab into master

What does this MR do and why?

Adds the capability to create an issue for the given finding from within the standalone finding modal.

Screenshots or screen recordings

Success

Screen_Recording_2023-04-12_at_3.27.24_pm

Error

Screen_Recording_2023-04-12_at_3.29.59_pm

How to set up and validate locally

Setup

  1. You'll need an EE License
  2. You'll need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/svedova/test-remediations-v2
  4. Run a pipeline on master

You will need to enable a feature flag:

  1. echo "Feature.enable(:pipeline_security_dashboard_graphql)" | rails c

Validation

  1. Go to the pipeline's security report tab
  2. Click on a finding that does not have an issue associated
  3. Click on the "Create issue" button
  4. Verify that the loading indicator is showing, the issue gets created and the browser redirects to it
  5. Navigate back to the pipeline's security report tab
  6. Click on the same issue and verify that the issue note is displayed and the "Create issue" button is not showing

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #393376 (closed)

Edited by David Pisek

Merge request reports

Loading