Fix harbor integration test settings bug
What does this MR do and why?
Related to issues #390721 (closed) and &7650
-
Fix the bug of
Test settings
button of harbor integration page. Before this change, we only checked to see if the harbor instance was online, now we can check to see if theproject_name
username
password
are right. -
Add HTML required validation to
Project name
field.
Screenshots or screen recordings
How to set up and validate locally
Test settings bug
- Create an account of
https://demo.goharbor.io/
. - Create a project in GitLab.
- Click into the project detail page,
Settings
->Integrations
->Harbor
. - Input the
Harbor URL
Project Name
and incorrectHarbor username
andHarbor password
. - Click the
Test settings
. - It shows
Connection Successful
.
Project Name
Missing required validation for - Create an account of
https://demo.goharbor.io/
. - Create a project in GitLab.
- Click into the project detail page,
Settings
->Integrations
->Harbor
. - Input the
Harbor username
,Harbor password
, clickSave changes
. - You can see a HTML required tip under
Harbor URL
. - Input the
Harbor URL
, clickSave changes
. - You can see the
Project Name
doesn't have HTML required message.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Zehua Zhang