Skip to content

Cache inexistence of the GitHub username when importing a repo to GitLab

Tetiana Zavediuk requested to merge tz-385777-cache-inexistence-of-github-username into master

What does this MR do and why?

It adds the rescue Octokit::NotFound exception inside the UserFinder and also cache the inexistence of the user to not make several requests to the GitHub API fetching the same information about the user. It also removes rescuing this exception in the GitHub import importers:

  • Gitlab::GithubImport::Importer::PullRequestReviewImporter
  • Gitlab::GithubImport::Importer::PullRequestMergedByImporter

It implements #385777 (closed).

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

Edited by Tetiana Zavediuk

Merge request reports