Skip to content

Add missing and required group for triage-ops

Ash McKenzie requested to merge ashmckenzie/add-missing-triage-ops-group into master

What does this MR do and why?

This MR adds the creation of the gitlab-com/support group for the db/fixtures/development/33_triage_ops.rb DB seed. Without this creation, the following error is displayed in the terminal when you start up the triage-ops server:

{"name":"sucker_punch","hostname":"amckenzie-m1-max","pid":74617,"severity":"ERROR","time":"2023-04-11T15:40:45.903+10:00","message":"Server responded with code 404, message: 404 Group Not Found. Request URI: http://gdk.test:3000/api/v4/groups/gitlab-com%2Fsupport/members","err":{"name":"Gitlab::Error::NotFound","message":"Server responded with code 404, message: 404 Group Not Found. Request URI: http://gdk.test:3000/api/v4/groups/gitlab-com%2Fsupport/members","stack":"/Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/gitlab-4.19.0/lib/gitlab/request.rb:71:in `validate'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/gitlab-4.19.0/lib/gitlab/request.rb:55:in `block (2 levels) in <class:Request>'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/gitlab-4.19.0/lib/gitlab/client/groups.rb:71:in `group_members'\n  /Users/ash/src/gitlab/triage-ops/triage/triage.rb:121:in `fresh_group_members'\n  /Users/ash/src/gitlab/triage-ops/triage/triage.rb:108:in `block in group_members'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/mini_cache-1.1.0/lib/mini_cache/store.rb:62:in `set'\n  /Users/ash/src/gitlab/triage-ops/triage/triage.rb:107:in `public_send'\n  /Users/ash/src/gitlab/triage-ops/triage/triage.rb:107:in `group_members'\n  /Users/ash/src/gitlab/triage-ops/triage/triage.rb:94:in `group_member_attrs'\n  /Users/ash/src/gitlab/triage-ops/triage/triage.rb:81:in `block (3 levels) in singleton class'\n  /Users/ash/src/gitlab/triage-ops/triage/job/keep_cache_warm_job.rb:21:in `public_send'\n  /Users/ash/src/gitlab/triage-ops/triage/job/keep_cache_warm_job.rb:21:in `block (2 levels) in refresh'\n  /Users/ash/src/gitlab/triage-ops/triage/job/keep_cache_warm_job.rb:20:in `each'\n  /Users/ash/src/gitlab/triage-ops/triage/job/keep_cache_warm_job.rb:20:in `block in refresh'\n  /Users/ash/src/gitlab/triage-ops/triage/job/keep_cache_warm_job.rb:19:in `each'\n  /Users/ash/src/gitlab/triage-ops/triage/job/keep_cache_warm_job.rb:19:in `refresh'\n  /Users/ash/src/gitlab/triage-ops/triage/job/keep_cache_warm_job.rb:13:in `execute'\n  /Users/ash/src/gitlab/triage-ops/triage/triage/job.rb:37:in `perform'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/sucker_punch-3.1.0/lib/sucker_punch/job.rb:63:in `__run_perform'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/sucker_punch-3.1.0/lib/sucker_punch/job.rb:38:in `block in perform_async'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:352:in `run_task'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:343:in `block (3 levels) in create_worker'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:334:in `loop'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:334:in `block (2 levels) in create_worker'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:333:in `catch'\n  /Users/ash/.asdf/installs/ruby/3.0.5/lib/ruby/gems/3.0.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:333:in `block in create_worker'"},"klass":"Triage::KeepCacheWarmJob","args":[]}

How to set up and validate locally

  1. From the triage-ops master branch, run the triage-ops server locally and observe the error output as described above.
  2. In a separate tab, boot up your GDK, ensuring you have an EE licence.
  3. In <GDK_ROOT>/gitlab, checkout the ashmckenzie/add-missing-triage-ops-group branch and run bundle exec rake db:seed_fu FILTER=33_triage_ops SEED_TRIAGE_OPS=true.
  4. Ensure the seed is processed without error (!117202 (merged) is required to be merged).
  5. From the triage-ops master branch, run the triage-ops server locally and observe the error is gone.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports