Refactor slug environment specs and code
What does this MR do and why?
This MR refactors slug environment specs and code and fixes the following
-
RSpec/UselessDynamicDefinition
- #406761 (closed) RSpec/MissingFeatureCategory
Style/StringConcatenation
It also runs the slug specs in random order.
How to set up and validate locally
bundle exec rubocop spec/lib/gitlab/slug/environment_spec.rb lib/gitlab/slug/environment.rb
bin/rspec spec/lib/gitlab/slug/environment_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #406761 (closed)
Edited by Peter Leitzen